[PATCH] D149996: [test] [ExecutionEngine] Skip the ExecutionEngine tests on mingw targets

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 5 14:38:50 PDT 2023


mstorsjo created this revision.
mstorsjo added reviewers: sgraenitz, lhames.
Herald added a project: All.
mstorsjo requested review of this revision.
Herald added a project: LLVM.

These tests used to be supported (somewhat) for mingw targets,
but since c42c67ad60449fe19949f2664c2a5878b3f72b7e <https://reviews.llvm.org/rGc42c67ad60449fe19949f2664c2a5878b3f72b7e>, which made
Orc the default JIT engine, these tests are failing. (That commit
made most tests under the ExecutionEngine/MCJIT directory run with
both "lli -jit-kind=mcjit" for explicitly running with MCJIT, and
with just plain "lli" which defaults to Orc.)

Orc doesn't seem to work for mingw targets; most tests fail with
an undefined reference to the "__main" symbol.

While fixing it would be better than just marking the tests as
unsupported, this works as a stopgap measure, unblocking running
the rest of the LLVM tests.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149996

Files:
  llvm/test/ExecutionEngine/lit.local.cfg


Index: llvm/test/ExecutionEngine/lit.local.cfg
===================================================================
--- llvm/test/ExecutionEngine/lit.local.cfg
+++ llvm/test/ExecutionEngine/lit.local.cfg
@@ -1,6 +1,12 @@
 if config.root.native_target in ['Sparc', 'PowerPC', 'SystemZ', 'Hexagon', 'RISCV']:
     config.unsupported = True
 
+# FIXME: Most tests fail for MinGW targets with Orc, where they do succeed
+# with the MCJIT backend; they fail with undefined references to the "__main"
+# symbol.
+if 'windows-gnu' in config.host_triple:
+    config.unsupported = True
+
 # ExecutionEngine tests are not expected to pass in a cross-compilation setup.
 if 'native' not in config.available_features:
     config.unsupported = True


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149996.519976.patch
Type: text/x-patch
Size: 737 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230505/5b3ff4f5/attachment.bin>


More information about the llvm-commits mailing list