[PATCH] D149941: [llvm][TargetParser] Create new Architecture base classes

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 5 14:28:28 PDT 2023


mehdi_amini added inline comments.


================
Comment at: llvm/include/llvm/TargetParser/Architecture/IDefaultFormatProvider.h:15
+namespace llvm {
+class IDefaultFormatProvider {
+public:
----------------
If you could document everything that is public (and non-trivial things in general), that would help. Right now reading the patch is a bit hard..


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149941/new/

https://reviews.llvm.org/D149941



More information about the llvm-commits mailing list