[PATCH] D149572: [LegalizeVectorOps][AArch64][RISCV][X86] Use OpVT for ISD::SETCC in LegalizeVectorOps.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 5 11:23:36 PDT 2023


RKSimon added a comment.

> I would prefer to make FP compares be identified by FP types, and integer compares identified by integer types.

Agreed - using the operand type whenever possible makes more sense to me.



================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:2603
+           Num * Cost;
+  }
+
----------------
Is there anyone intending to deal with this FIXME?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149572/new/

https://reviews.llvm.org/D149572



More information about the llvm-commits mailing list