[PATCH] D149707: [Demangle] remove unused status param of itaniumDemangle

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 5 09:56:54 PDT 2023


nickdesaulniers added a comment.

In D149707#4322536 <https://reviews.llvm.org/D149707#4322536>, @nickdesaulniers wrote:

> In D149707#4320929 <https://reviews.llvm.org/D149707#4320929>, @barannikov88 wrote:
>
>> @nickdesaulniers This function is used in a couple more places:
>>
>>> /mnt/d/llvm-project/llvm/lib/Target/SPIRV/SPIRVUtils.cpp:298:25: error: no matching function for call to 'itaniumDemangle'
>>>
>>>   char *DemangledName = itaniumDemangle(Name.data(), nullptr, &n, &Status);
>>>                         ^~~~~~~~~~~~~~~
>>
>>
>>
>>> /mnt/d/llvm-project/llvm/lib/Target/SPIRV/SPIRVRegularizer.cpp:176:19: error: no matching function for call to 'itaniumDemangle'
>>>
>>>   char *NameStr = itaniumDemangle(F->getName().data(), nullptr, &n, &status);
>>>                   ^~~~~~~~~~~~~~~
>
> Thanks for the report.  Looks like my code indexer is only indexing backends I build; none of the experimental ones were enabled. I'm working on a fix immediately, and will triple check for other callers using grep.

Nevermind, @MaskRay fixed this up in 8e6b3cc4aeedb864a983d849498c03b074570406 <https://reviews.llvm.org/rG8e6b3cc4aeedb864a983d849498c03b074570406>. Thanks @MaskRay !


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149707/new/

https://reviews.llvm.org/D149707



More information about the llvm-commits mailing list