[PATCH] D149967: [AArch64][SVE] Enable shouldFoldSelectWithIdentityConstant for SVE.

Paul Walker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 5 09:19:38 PDT 2023


paulwalker-arm added a comment.

I don't get the argument here.  To me the instcombine canonical form is better because it results in reduce operand use counts. I also don't understand how this canonical IR form is less natural for SVE given ISel patterns already exist (albeit not all ops have been covered yet).  This just looks like an artificial and unnecessary switch and so perhaps you can share a better rational?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149967/new/

https://reviews.llvm.org/D149967



More information about the llvm-commits mailing list