[PATCH] D142318: [Support] Add PerThreadBumpPtrAllocator class.

Andrew Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 5 02:36:28 PDT 2023


andrewng accepted this revision.
andrewng added a comment.

Apart from the minor suggestion, all the `parallel` changes LGTM.



================
Comment at: llvm/lib/Support/Parallel.cpp:112
 
+  size_t getThreadsNum() const override { return ThreadCount; }
+
----------------
Perhaps change `getThreadsNum` -> `getNumThreads` or `getThreadCount`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142318/new/

https://reviews.llvm.org/D142318



More information about the llvm-commits mailing list