[PATCH] D149918: [InstCombine] Add oneuse checks to shr + cmp constant folds.

[Amara Emerson via Phabricator via llvm-commits]

aemerson added a comment.

In D149918#4320934 <https://reviews.llvm.org/D149918#4320934>, @goldstein.w.n wrote:

> Where are the codegen improvements coming from?
> Better `imm` values or something? Personally this feels a bit of a hack at the expense of potential ILP.

I'll look into exactly what changed in the codegen tomorrow. Why does this feel like a hack as opposed to all the other hasOneUse() checks in the optimizers?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149918/new/

https://reviews.llvm.org/D149918