[PATCH] D149893: Rewrite LSV to handle longer chains.

[Justin Lebar via Phabricator via llvm-commits]

jlebar added a comment.

Thanks for the comments, Matt.  I've addressed them.

It looks like I missed a bunch of AMDGPU codegen test failures.  I didn't realize that our infra at Google was skipping these.  I will have a look.



================
Comment at: llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:955
+      if (V->getType() != I->getType()) {
+        V = Builder.CreateBitOrPointerCast(V, I->getType());
+      }
----------------
arsenm wrote:
> This shouldn't introduce addrspacecasts 
True, but it does have the potential to do a bitcast (e.g. i32 -> float) or an inttoptr (e.g. int64 -> ptr).  Is that the wrong function to call?

Maybe you just meant to put this on the `Value *Bitcast = Builder.CreateBitOrPointerCast(` above -- that one I think can be just a BitCast.  Changed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149893/new/

https://reviews.llvm.org/D149893