[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions
Alexander Shaposhnikov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 4 18:19:32 PDT 2023
alexander-shaposhnikov added inline comments.
================
Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:133
}
+Response HandlePartialClassTemplateSpec(
----------------
alexander-shaposhnikov wrote:
> HandlePartialClassTemplateSpec is from Erich's diff (https://reviews.llvm.org/D147722)
@erichkeane : previously (see https://reviews.llvm.org/D147722) we were producing a real layer of arguments (if the depth is greater than 1), to the best of my knowledge this is incorrect since it'd trigger unexpected depth adjustment, we should produce retained layers instead.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146178/new/
https://reviews.llvm.org/D146178
More information about the llvm-commits
mailing list