[PATCH] D149901: [RISCV] Restrict valid indices for cm.jalt to be in [32,255].

Jessica Clarke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 4 14:17:37 PDT 2023


jrtc27 added a comment.

In D149901#4320183 <https://reviews.llvm.org/D149901#4320183>, @craig.topper wrote:

> In D149901#4320157 <https://reviews.llvm.org/D149901#4320157>, @jrtc27 wrote:
>
>> Dumb question: how's the disassembler disambiguating here? By chance due to cm.jt coming first and matching only when the upper bits are 0 (i.e. fragilely)?
>
> Yes, but I don't think its fragile. The disassembler generator prioritizes the more exact match for 12-10 being 0 from the cm.jt definition.

Ok, if it's done that way rather than order I guess it's fine


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149901/new/

https://reviews.llvm.org/D149901



More information about the llvm-commits mailing list