[PATCH] D149893: Rewrite LSV to handle longer chains.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:672-676
+unsigned Vectorizer::getTypeSizeInBytes(Type *ty) {
+  unsigned SzBits = DL.getTypeSizeInBits(ty);
+  assert(SzBits % 8 == 0);
+  return SzBits / 8;
+}
----------------
This is reinventing DL.getTypeStoreSize


================
Comment at: llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:955
+      if (V->getType() != I->getType()) {
+        V = Builder.CreateBitOrPointerCast(V, I->getType());
+      }
----------------
This shouldn't introduce addrspacecasts 


================
Comment at: llvm/lib/Transforms/Vectorize/LoadStoreVectorizer.cpp:1013
+        Vec,
+        Builder.CreateBitOrPointerCast(getLoadStorePointerOperand(C[0].Inst),
+                                       VecTy->getPointerTo(AS)),
----------------
Ditto 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149893/new/

https://reviews.llvm.org/D149893