[llvm] d1d4e56 - [llvm-profdata] Change default output format of llvm-profdata to ExtBinary

William Huang via llvm-commits llvm-commits at lists.llvm.org
Thu May 4 12:34:49 PDT 2023


Author: William Huang
Date: 2023-05-04T19:34:12Z
New Revision: d1d4e56433c193e6fff48f0fbf0c0fac14b93acc

URL: https://github.com/llvm/llvm-project/commit/d1d4e56433c193e6fff48f0fbf0c0fac14b93acc
DIFF: https://github.com/llvm/llvm-project/commit/d1d4e56433c193e6fff48f0fbf0c0fac14b93acc.diff

LOG: [llvm-profdata] Change default output format of llvm-profdata to ExtBinary

ExtBinary is compatible to, and more superior than Binary format, which is the current default output format. In the long run we are looking to only support ExtBinary format and Text format (for visual inspection), and drop Binary format as well. Since Binary format was the default, we expect many users are still using it, so let's change the default output format first, and hopefully the usage decreases over time

Reviewed By: davidxl, hoy

Differential Revision: https://reviews.llvm.org/D149700

Added: 
    

Modified: 
    llvm/tools/llvm-profdata/llvm-profdata.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-profdata/llvm-profdata.cpp b/llvm/tools/llvm-profdata/llvm-profdata.cpp
index d3dc26aa28855..a6f7b5256a2d7 100644
--- a/llvm/tools/llvm-profdata/llvm-profdata.cpp
+++ b/llvm/tools/llvm-profdata/llvm-profdata.cpp
@@ -1182,10 +1182,11 @@ static int merge_main(int argc, const char *argv[]) {
       cl::values(clEnumVal(instr, "Instrumentation profile (default)"),
                  clEnumVal(sample, "Sample profile")));
   cl::opt<ProfileFormat> OutputFormat(
-      cl::desc("Format of output profile"), cl::init(PF_Binary),
+      cl::desc("Format of output profile"), cl::init(PF_Ext_Binary),
       cl::values(
-          clEnumValN(PF_Binary, "binary", "Binary encoding (default)"),
-          clEnumValN(PF_Ext_Binary, "extbinary", "Extensible binary encoding"),
+          clEnumValN(PF_Binary, "binary", "Binary encoding"),
+          clEnumValN(PF_Ext_Binary, "extbinary", "Extensible binary encoding "
+                     "(default)"),
           clEnumValN(PF_Text, "text", "Text encoding"),
           clEnumValN(PF_GCC, "gcc",
                      "GCC encoding (only meaningful for -sample)")));


        


More information about the llvm-commits mailing list