[PATCH] D149421: [KnownBits] Improve `KnownBits::rem(X, Y)` in cases where we can deduce low-bits of output

Noah Goldstein via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 4 09:39:49 PDT 2023


goldstein.w.n marked 3 inline comments as done.
goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Support/KnownBits.cpp:561
+    KnownOut.Zero |= ZerosMask;
+    return KnownOut;
+  }
----------------
RKSimon wrote:
> return KnownBits(ZerosMask, OnesMask)
Sure, although this is private so need to put this function in the class then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149421/new/

https://reviews.llvm.org/D149421



More information about the llvm-commits mailing list