[PATCH] D149842: Scalarizer: limit scalarization for small element types

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 4 07:56:39 PDT 2023


arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/Scalarizer.cpp:67-69
+    "scalarize-min-bits", cl::init(0), cl::Hidden,
+    cl::desc("Instruct the scalarizer pass to attempt to keep values of a "
+             "minimum number of bits"));
----------------
Should this go based on legal vector operations from TTI?

Alternatively, would we just scalarize everything and then run SLPVectorizer?


================
Comment at: llvm/lib/Transforms/Scalar/Scalarizer.cpp:439
+        return CV[Frag];
+      } else if (VS.NumPacked == 1 && !CV[J]) {
         // Only cache the first entry we find for each index we're not actively
----------------
No else after return 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149842/new/

https://reviews.llvm.org/D149842



More information about the llvm-commits mailing list