[PATCH] D147964: [VPlan] Introduce new entry block to VPlan for early SCEV expansion.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3261
+       [ ] <-- old preheader - loop iteration number check and SCEVs in Plan's
+     /  |      preheader are expanded here. Eventually all required SCEV
+    /   |      expansion should happen here.
----------------
Ayal wrote:
> (post-commit nit): so have we reached this "Eventually" situation?
There are some places still remaining that do manual SCEV expansion, e.g. when creating induction resume values. This should be addressed by D147965.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147964/new/

https://reviews.llvm.org/D147964