[PATCH] D149699: [InstCombine] Improve bswap optimization

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:1288
+    // removed have no other uses.
+    if (match(X, m_Intrinsic<IntrID>(m_Value(OldReorder))) && X->hasOneUse()) {
+      Value *NewReorder = Builder.CreateUnaryIntrinsic(IntrID, Y);
----------------
match(X, m_OneUse(m_Intrinsic<IntrID>(m_Value(OldReorder)))) ?


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCalls.cpp:1291
+      return BinaryOperator::Create(Op, OldReorder, NewReorder);
+    } else if (match(Y, m_Intrinsic<IntrID>(m_Value(OldReorder))) &&
+               Y->hasOneUse()) {
----------------
match(Y, m_OneUse(m_Intrinsic<IntrID>(m_Value(OldReorder)))) ?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149699/new/

https://reviews.llvm.org/D149699