[PATCH] D149833: [X86] Omit predicate In64BitMode for instructions w/ GP64 operand in X86InstrArithmetic.td, NFCI
Kan Shengchen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 4 02:54:33 PDT 2023
skan created this revision.
Herald added subscribers: pengfei, hiraditya.
Herald added a project: All.
skan requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
As we discussed in D138639 <https://reviews.llvm.org/D138639>, we usually omit `In64BitMode` on instructions that
have a GR64 operand b/c
1. Assembler would never parse a GR64 register name outside of 64-bit mode
2. GR64 is not legal during ISEL outside of 64-bit mode
3. Adding them might increase the size of the table in X86GenDAGISel.inc
I will do similar clean in other files if this patch is accepted.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D149833
Files:
llvm/lib/Target/X86/X86InstrArithmetic.td
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149833.519407.patch
Type: text/x-patch
Size: 6331 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230504/208c2c63/attachment.bin>
More information about the llvm-commits
mailing list