[PATCH] D149522: [JITLink] Add target features to LinkGraph

Lang Hames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 4 01:56:11 PDT 2023

lhames added a comment.

Another quick skim (I'm back in the office on Monday and I can take a proper look then).

> However, this introduces a dependency from JITLink on MC and I'm not quite sure if this is warranted. If not, the features could be stored as std::vector<std::string> (the underlying storage of SubtargetFeatures).

Yeah -- we definitely want to avoid the dependence on MC. One of the aims of ORC development over the next year or so is going to be splitting the library up so that ORC core depends only on libObject (and eventually, only on format-specific object file parsing libraries, but we don't have those yet. :) )

- Lang.

  rG LLVM Github Monorepo



More information about the llvm-commits mailing list