[PATCH] D147963: [LV] Use VPValue for SCEV expansion in fixupIVUsers.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 2 inline comments as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3384
+
+      VPValue *StepVPV = Plan.getSCEVExpansion(II.getStep());
+      Value *Step = StepVPV->getDefiningRecipe() ? State.get(StepVPV, 0)
----------------
Ayal wrote:
> nit: worth asserting that step SCEV is expected to have a VPValue?
Added an assert in the committed version, thanks!


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3385-3386
+      VPValue *StepVPV = Plan.getSCEVExpansion(II.getStep());
+      Value *Step = StepVPV->getDefiningRecipe() ? State.get(StepVPV, 0)
+                                                 : StepVPV->getLiveInIRValue();
       Value *Escape =
----------------
Ayal wrote:
> 
Updated in the committed version, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147963/new/

https://reviews.llvm.org/D147963