[PATCH] D149124: [llvm-profdata] ProfileReader cleanup - preparation for MD5 refactoring - 3

William Junda Huang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 22:21:16 PDT 2023


huangjd added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/SampleProfReader.h:640
-  /// Return true if we've reached the end of file.
-  bool at_eof() const { return Data >= End; }
-
----------------
This function is misleading and only used once.  Data>=End does not imply at EOF in ExtBinary, so removing it. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149124/new/

https://reviews.llvm.org/D149124



More information about the llvm-commits mailing list