[PATCH] D149729: [X86] Avoid usage constant NaN for fminimum/fmaximum lowering

[Serguei Katkov via Phabricator via llvm-commits]

skatkov marked 4 inline comments as done.
skatkov added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:30283
+  if (IgnoreSingedZero || IsPreferredZero(Y) || DAG.isKnownNeverZeroFloat(X)) {
   } else if (IsPreferredZero(X) || DAG.isKnownNeverZeroFloat(Y)) {
+    NewX = Y;
----------------
e-kud wrote:
> This is a little out of code-style to have an empty `if`. I don't see any of it in `lib/Target/X86`. Can we reorganize somehow to avoid it?
instead of re-factoring, I decided to make it explicit that X and Y are not re-ordered. So block becomes non-empty.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149729/new/

https://reviews.llvm.org/D149729