[PATCH] D149580: [hwasan] support hwasan-match-all-tag flag for callback memory access instrumentation

[Mingjie Xu via Phabricator via llvm-commits]

Enna1 added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:994
+           IRB.CreateUDiv(IRB.CreateTypeSize(IntptrTy, O.TypeStoreSize),
+                          ConstantInt::get(IntptrTy, 8)),
+           ConstantInt::get(Int8Ty, *MatchAllTag)});
----------------
vitalybuka wrote:
> Int8ptrTy and one below
Sorry, I don't get it.
Here we call `ConstantInt::get(IntptrTy, 8)` to create a constant int value 8, `O.TypeStoreSize` represents size in bits, and `O.TypeStoreSize` divided by 8 represents size in bytes.
We should not use Int8ptrTy here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149580/new/

https://reviews.llvm.org/D149580