[PATCH] D147965: [LV] Use VPValue to get expanded value for SCEV step expressions (WIP).

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 14:53:02 PDT 2023


Ayal added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:3235
     PHINode *OrigPhi = InductionEntry.first;
     const InductionDescriptor &II = InductionEntry.second;
     PHINode *BCResumeVal = createInductionResumeValue(
----------------
Suffice to retrieve Step here from II, Plan, and State, and pass it to createInductionResumeValue()?
Getting the Value expanded from a SCEV possibly deserves wrapping in a common function.
(Admittedly not saving much.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147965/new/

https://reviews.llvm.org/D147965



More information about the llvm-commits mailing list