[PATCH] D149400: [llvm-profdata] Deprecate Compact Binary Sample Profile Format

Wed May 3 14:17:47 PDT 2023

davidxl added a comment.

In D149400#4316855 <https://reviews.llvm.org/D149400#4316855>, @manojgupta wrote:

> We have been using compbinary format in ChromeOS. Now it fails with the the following error:
>
> `llvm-profdata merge: Did you mean '--binary'? `
>
> Can you please suggest the fix? The current usages are:
>
> 1. https://source.chromium.org/chromium/chromiumos/overlays/chromiumos-overlay/+/main:eclass/cros-kernel2.eclass;l=2397
> 2. https://source.chromium.org/chromium/chromiumos/chromite/+/main:lib/toolchain_util.py;l=1038
>
> The reason for using compbinary is that it uses lower memory.
>
>   # Compressed binary profiles are lazily loaded, so they save a
>   		# meaningful amount of CPU and memory per clang invocation. 

I suggest switching to extended binary format for now.   williamjhuang@'s follow up improvement patches will greatly improve memory and CPU usage for extbinary format (should be better than compact format).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149400/new/

https://reviews.llvm.org/D149400