[PATCH] D149699: [InstCombine][DAGCombiner] Improve bswap optimization

[Austin Chang via Phabricator via llvm-commits]

austin880625 added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp:10756
 
+  // fold (bswap (logic_op(bswap(x),y))) -> logic_op(x,bswap(y))
+  // Need to ensure logic_op and bswap(x) doesn't have other uses
----------------
nikic wrote:
> goldstein.w.n wrote:
> > Likewise a helper here so it can be easily extended to handle bitreverse/any other intrinsics that it applies to.
> > Also, there are no tests for the DAGCombiner changes at the moment.
> In any case, this should be part of a separate patch, not mixed with InstCombine changes.
oh I just see the new comment. Let me separate this again


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149699/new/

https://reviews.llvm.org/D149699