[PATCH] D149780: [WebAssembly] Remove incorrect result from wasm64 store_lane instructions

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 12:38:48 PDT 2023


tlively created this revision.
tlively added a reviewer: sbc100.
Herald added subscribers: pmatos, asb, wingo, ecnelises, sunfish, hiraditya, jgravelle-google, dschuff.
Herald added a project: All.
tlively requested review of this revision.
Herald added subscribers: llvm-commits, aheejin.
Herald added a project: LLVM.

The wasm64 versions of the v128.storeX_lane instructions was incorrectly defined
as returning a v128 value, which resulted in spurious drop instructions being
emitted and causing validation to fail. This was not caught earlier because
wasm64 has been experimental and not well tested. Update the relevant test file
to test both wasm32 and wasm64.

Fixes #62443.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149780

Files:
  llvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
  llvm/test/CodeGen/WebAssembly/simd-load-lane-offset.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149780.519212.patch
Type: text/x-patch
Size: 39123 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230503/f2fda69f/attachment.bin>


More information about the llvm-commits mailing list