[PATCH] D149760: [llvm][test] Skip physical filesystem test if unsupported
Ben Langmuir via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 3 12:14:52 PDT 2023
This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rG562cd31ebd30: [llvm][test] Skip physical filesystem test if unsupported (authored by benlangmuir).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149760/new/
https://reviews.llvm.org/D149760
Files:
llvm/unittests/Support/VirtualFileSystemTest.cpp
Index: llvm/unittests/Support/VirtualFileSystemTest.cpp
===================================================================
--- llvm/unittests/Support/VirtualFileSystemTest.cpp
+++ llvm/unittests/Support/VirtualFileSystemTest.cpp
@@ -537,7 +537,9 @@
llvm::make_scope_exit([&] { sys::fs::set_current_path(PrevWD); });
// Delete the working directory to create an error.
- ASSERT_EQ(sys::fs::remove_directories(WD), std::error_code());
+ if (sys::fs::remove_directories(WD, /*IgnoreErrors=*/false))
+ // Some platforms (e.g. Solaris) disallow removal of the working directory.
+ GTEST_SKIP() << "test requires deletion of working directory";
// Verify that we still get two separate working directories.
auto FS1 = vfs::createPhysicalFileSystem();
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149760.519201.patch
Type: text/x-patch
Size: 774 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230503/1e79818b/attachment.bin>
More information about the llvm-commits
mailing list