[PATCH] D149721: EntryExitInstrumenter: skip naked functions

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D149721#4314910 <https://reviews.llvm.org/D149721#4314910>, @hans wrote:

> Seems reasonable to me.
>
> Would `-fprofile-instr-generate` and `-fprofile-generate` have the same issue?

No. The two instrumentations don't insert calls, and are therefore unaffected.

`-fsanitize-coverage=` works with `naked` by skipping an entry block ending with an unreachable.

> Do we have any docs about the naked attribute that should be updated?

I think a doc need isn't strong, and even if does, the doc need likely belongs to the individual instrumentation features.
An instrumentation may skip many functions and we don't document all of them...

For this patch, I think there isn't anything to update...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149721/new/

https://reviews.llvm.org/D149721