[PATCH] D149627: [NFC][SLP] Cleanup: Simplify traversal loop in SLPVectorizerPass::vectorizeHorReduction().
Alexey Bataev via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 3 10:41:27 PDT 2023
ABataev added inline comments.
================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:14097
+ assert(Stack.empty() &&
+ "This checks that changing `continue` to `break` was correct.");
+ break;
----------------
vporpo wrote:
> ABataev wrote:
> > Replace the message with something meaningful, like 'Empty Stack is expected.'
> I think we should also mention why we are checking that Stack is empty, so that we know how to fix this if it triggers the assertion. How about: "Empty Stack expected. Change `break` to `continue`?"
The change continue to break is actual only for this patch, not for the codebase. So just `Empty stack expected, the original root is reached` or something like this should be enough
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149627/new/
https://reviews.llvm.org/D149627
More information about the llvm-commits
mailing list