[PATCH] D149173: [llvm][vfs] Avoid silent fallback to process-wide working directory

Ben Langmuir via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 09:26:09 PDT 2023


benlangmuir added a comment.

@ro thanks for letting me know; this should skip the test if the removal fails: https://reviews.llvm.org/D149760.  I looked to see if there was another way to get `getcwd` to fail inside `createPhysicalFileSystem` but it seems the only other idea would be EACCESS, but I see a note "This is only checked in limited cases, depending on implementation details." so it doesn't seem like a great choice either.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149173/new/

https://reviews.llvm.org/D149173



More information about the llvm-commits mailing list