[PATCH] D149729: [X86] Avoid usage constant NaN for fminimum/fmaximum lowering

[Noah Goldstein via Phabricator via llvm-commits]

goldstein.w.n added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:30276
 
   SDValue MinMax;
   bool IsXNeverNaN = DAG.isKnownNeverNaN(X);
----------------
This doesn't need to be fwd declared anymore.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:30279
   bool IsYNeverNaN = DAG.isKnownNeverNaN(Y);
-  if (DAG.getTarget().Options.NoSignedZerosFPMath ||
-      Op->getFlags().hasNoSignedZeros() || IsPreferredZero(Y) ||
-      DAG.isKnownNeverZeroFloat(X)) {
-    MinMax = DAG.getNode(MinMaxOp, DL, VT, X, Y, Op->getFlags());
+  bool IgnoreSingedZero = DAG.getTarget().Options.NoSignedZerosFPMath ||
+                           Op->getFlags().hasNoSignedZeros();
----------------
'Singed' -> 'Signed'


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149729/new/

https://reviews.llvm.org/D149729