[PATCH] D148984: [Support][Parallel] Change check for nested TaskGroups.
Andrew Ng via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 3 07:59:47 PDT 2023
andrewng accepted this revision.
andrewng added a comment.
This revision is now accepted and ready to land.
In your description, perhaps change `avoid` -> `prevents` in `TaskGroups can work parallelly but current check avoid this.`
Apart from the nits, LGTM.
================
Comment at: llvm/include/llvm/Support/Parallel.h:103
+
+ bool isParallel() { return Parallel; }
};
----------------
Make `const`.
================
Comment at: llvm/unittests/Support/ParallelTest.cpp:149
+ EXPECT_FALSE(nestedTG.isParallel());
+ Count++;
+
----------------
Perhaps `++Count`? And the same for below...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148984/new/
https://reviews.llvm.org/D148984
More information about the llvm-commits
mailing list