[PATCH] D149658: [RISCV] Use vslidedown for undef sub-sequences in generic build_vector

Luke Lau via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 02:45:38 PDT 2023


luke added a comment.

> A question for reviewers. This could also be written as a set of DAG combines and achieve the same effect. I'd actually written it that way originally, but given a) it didn't catch anything beyond the buildvec case and b) preference expressed in previous reviews, I switched over. Which do we prefer here?

I also wrote a DAG combine for merging vslide1downs of undefs to vslidedown locally, and can confirm that it didn't catch anything else.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149658/new/

https://reviews.llvm.org/D149658



More information about the llvm-commits mailing list