[PATCH] D149610: [llvm-objdump][COFF] Skip empty entries when dumping the export table

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 02:32:04 PDT 2023


mstorsjo added a comment.

In D149610#4314907 <https://reviews.llvm.org/D149610#4314907>, @hans wrote:

> In D149610#4312974 <https://reviews.llvm.org/D149610#4312974>, @aganea wrote:
>
>> @hans @alvinhochun The rationale is to simply remove noise from the output when there are sparse ordinals in the table.
>
> Fair enough. If sparse tables are a thing and other tools do it too, I suppose that makes sense.

As long as the tool does print what the actual initial value was (which iirc it does?) I guess it makes sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149610/new/

https://reviews.llvm.org/D149610



More information about the llvm-commits mailing list