[PATCH] D123515: [RISCV] Support '.option arch' directive

luxufan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 3 01:55:50 PDT 2023


StephenFan added a comment.

In D123515#4248222 <https://reviews.llvm.org/D123515#4248222>, @luismarques wrote:

> Thanks for all of the improvements so far.
>
> Two additional problems I noticed:
>
> 1. It currently accepts non-extension features like `.option arch, +svnapot, +relax`.

`svnapot` can be parsed from arch string. I think we need an API in RISCVISAInfo to decide that some extensions are non-extension features, only rejecting in the logic of parse .option arch directive seems tricky.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123515/new/

https://reviews.llvm.org/D123515



More information about the llvm-commits mailing list