[PATCH] D149703: [Demangle] remove unused params of itaniumDemangle

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 16:40:34 PDT 2023


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM to remove `char *buf, size_t *n,`. If a user somewhat needs the parameters, we can add another API.



================
Comment at: llvm/lib/ProfileData/GCOV.cpp:343
+        char *res = itaniumDemangle(Name.data(), &status);
         if (status == 0) {
           demangled = res;
----------------
`llvm-cov gcov` uses `status`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149703/new/

https://reviews.llvm.org/D149703



More information about the llvm-commits mailing list