[PATCH] D149700: [llvm-profdata] Change default output format of llvm-profdata to ExtBinary

[William Junda Huang via Phabricator via llvm-commits]

huangjd created this revision.
huangjd added reviewers: davidxl, xur, snehasish, wenlei, hoy.
Herald added a subscriber: wlei.
Herald added a project: All.
huangjd requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

ExtBinary is compatible to, and more superior than Binary format, which is the current default output format. In the long run we are looking to only support ExtBinary format and Text format (for visual inspection), and drop Binary format as well. Since Binary format was the default, we expect many users are still using it, so let's change the default output format first, and hopefully the usage decreases over time


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149700

Files:
  llvm/tools/llvm-profdata/llvm-profdata.cpp


Index: llvm/tools/llvm-profdata/llvm-profdata.cpp
===================================================================
--- llvm/tools/llvm-profdata/llvm-profdata.cpp
+++ llvm/tools/llvm-profdata/llvm-profdata.cpp
@@ -1182,7 +1182,7 @@
       cl::values(clEnumVal(instr, "Instrumentation profile (default)"),
                  clEnumVal(sample, "Sample profile")));
   cl::opt<ProfileFormat> OutputFormat(
-      cl::desc("Format of output profile"), cl::init(PF_Binary),
+      cl::desc("Format of output profile"), cl::init(PF_Ext_Binary),
       cl::values(
           clEnumValN(PF_Binary, "binary", "Binary encoding (default)"),
           clEnumValN(PF_Ext_Binary, "extbinary", "Extensible binary encoding"),


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149700.518894.patch
Type: text/x-patch
Size: 713 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230502/94c9d75d/attachment.bin>