[PATCH] D149577: [InstCombine] Improve bswap optimization
Noah Goldstein via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 2 15:44:26 PDT 2023
goldstein.w.n added a comment.
In D149577#4313910 <https://reviews.llvm.org/D149577#4313910>, @austin880625 wrote:
> @goldstein.w.n I updated the diff on this revision (as test) and created another D149699 <https://reviews.llvm.org/D149699> as updated implementation. Let me know if I did anything wrong here, thanks!
You created the series properly.
Can you update the summary/title of the two commits to reflect what they are now.
So D149577 <https://reviews.llvm.org/D149577> doesn't need a summary but the title should be something along the lines of:
"[InstCombine] Add tests for `(logic_op (bswap X), Y)`; NFC"
D149699 <https://reviews.llvm.org/D149699> should have basically the same title/commit as you originally had (as you have here now).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149577/new/
https://reviews.llvm.org/D149577
More information about the llvm-commits
mailing list