[PATCH] D149675: [LLD] fix llvm::demangle lifetime issue

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 13:48:03 PDT 2023


nickdesaulniers added a comment.

In D149675#4313532 <https://reviews.llvm.org/D149675#4313532>, @nickdesaulniers wrote:

> The call to `std::strlen(MangledName)` in `llvm::itaniumDemangle` looks suspicious and I'll bet we're having trouble demangling non-null terminated string_views.

Yeah, something funny going on where the MangledName.length() != std::strlen(MangledName.data()) for this test case. Digging...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149675/new/

https://reviews.llvm.org/D149675



More information about the llvm-commits mailing list