[PATCH] D149675: [LLD] fix llvm::demangle lifetime issue

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 12:00:54 PDT 2023


efriedma added a comment.

This doesn't make any sense.  If the argument "name" is live on entry to the function, it'll remain alive until the function exit.  Converting it to a string_view should maintain the same lifetime.  Converting it to an std::string actually makes the lifetime shorter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149675/new/

https://reviews.llvm.org/D149675



More information about the llvm-commits mailing list