[PATCH] D149610: [llvm-objdump][COFF] Skip empty entries when dumping the export table

Tue May 2 11:56:11 PDT 2023

aganea marked 3 inline comments as done.
aganea added inline comments.

================
Comment at: lld/test/COFF/export32.test:83
 # CHECK7:      Ordinal      RVA  Name
-# CHECK7-NEXT:       1        0
+# CHECK7-NEXT:       1   0x1010  exportfn3
 # CHECK7-NEXT:       2   0x1010  foo
----------------
mstorsjo wrote:
> aganea wrote:
> > mstorsjo wrote:
> > > This change doesn't seem consistent and/or directly explainable by the change itself?
> > The previous pattern was wrong. The RVA `0` was actually matching the first character of `0x1010`. 
> Ok, that makes sense. Please mention and explain that bit in the commit message then!
I could separate that in a commit as well, since it's not relevant to this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149610/new/

https://reviews.llvm.org/D149610