[PATCH] D149451: [NVPTX] Add NVPTXCtorDtorLoweringPass to handle global ctors / dtors

[Artem Belevich via Phabricator via llvm-commits]

tra accepted this revision.
tra added a comment.

LGTM.



================
Comment at: llvm/lib/Target/NVPTX/NVPTXCtorDtorLowering.cpp:31
+    GlobalStr("nvptx-lower-global-ctor-dtor-id",
+              cl::desc("Override the name of ctor/dtor globals."), cl::init(""),
+              cl::Hidden);
----------------
We're not overriding the name, but rather the unique suffix for the names we generate.
Perhaps rephrase along the lines of "Override unique ID for ctor/dtor globals" ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149451/new/

https://reviews.llvm.org/D149451