[PATCH] D149507: [SeparateConstOffsetFromGEP] Fix bug handling negative offsets

Tue May 2 08:34:50 PDT 2023

tstellar added a comment.

In D149507#4312221 <https://reviews.llvm.org/D149507#4312221>, @nikic wrote:

> In D149507#4312220 <https://reviews.llvm.org/D149507#4312220>, @tstellar wrote:
>
>> In D149507#4312067 <https://reviews.llvm.org/D149507#4312067>, @nikic wrote:
>>
>>> This looks reasonable to me, but maybe wait a bit in case @Peakulorain has a better suggestion.
>>>
>>> https://github.com/llvm/llvm-project/blob/1d0ccebcd725309399262af346494242b064e2ed/llvm/lib/Transforms/Scalar/SeparateConstOffsetFromGEP.cpp#L590-L593 is the code negating the offset.
>>
>> I actually meant to delete that code in this patch, so I've updated the patch to take it out.
>
> Hm, why is it safe to delete that code? Don't we still need it in the case where we have no extension or a sign extension?

Yes, I've added it back.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149507/new/

https://reviews.llvm.org/D149507