[PATCH] D149654: [SLP] Don't cost pointers that can be folded in getPointersChainCost
Luke Lau via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 2 08:13:34 PDT 2023
luke added inline comments.
================
Comment at: llvm/lib/Target/X86/X86TargetTransformInfo.cpp:4960
- }
- return BaseT::getPointersChainCost(Ptrs, Base, Info, CostKind);
-}
----------------
luke wrote:
> I removed this because it seems to be subsumed by the extra check in the base implementation. It's 100% equivalent as it will now cost for GEPs that don't fit into the addressing mode, but that should be more accurate right?
Typo, it's *not* 100% equivalent
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149654/new/
https://reviews.llvm.org/D149654
More information about the llvm-commits
mailing list