[llvm] 55678b4 - [CodeGen] One more use of MachineBasicBlock::phis. NFC.

[Jay Foad via llvm-commits]

Author: Jay Foad
Date: 2023-05-02T14:55:24+01:00
New Revision: 55678b43b5a2aa346eb95389c6f81f95e73f6944

URL: https://github.com/llvm/llvm-project/commit/55678b43b5a2aa346eb95389c6f81f95e73f6944
DIFF: https://github.com/llvm/llvm-project/commit/55678b43b5a2aa346eb95389c6f81f95e73f6944.diff

LOG: [CodeGen] One more use of MachineBasicBlock::phis. NFC.

Added: 
    

Modified: 
    llvm/lib/CodeGen/UnreachableBlockElim.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/UnreachableBlockElim.cpp b/llvm/lib/CodeGen/UnreachableBlockElim.cpp
index 549d902f3b79..f17450d264ba 100644
--- a/llvm/lib/CodeGen/UnreachableBlockElim.cpp
+++ b/llvm/lib/CodeGen/UnreachableBlockElim.cpp
@@ -120,16 +120,14 @@ bool UnreachableMachineBlockElim::runOnMachineFunction(MachineFunction &F) {
       while (BB.succ_begin() != BB.succ_end()) {
         MachineBasicBlock* succ = *BB.succ_begin();
 
-        MachineBasicBlock::iterator start = succ->begin();
-        while (start != succ->end() && start->isPHI()) {
-          for (unsigned i = start->getNumOperands() - 1; i >= 2; i-=2)
-            if (start->getOperand(i).isMBB() &&
-                start->getOperand(i).getMBB() == &BB) {
-              start->removeOperand(i);
-              start->removeOperand(i-1);
+        for (MachineInstr &Phi : succ->phis()) {
+          for (unsigned i = Phi.getNumOperands() - 1; i >= 2; i -= 2) {
+            if (Phi.getOperand(i).isMBB() &&
+                Phi.getOperand(i).getMBB() == &BB) {
+              Phi.removeOperand(i);
+              Phi.removeOperand(i - 1);
             }
-
-          start++;
+          }
         }
 
         BB.removeSuccessor(BB.succ_begin());