[PATCH] D147424: [MC][AMDGPU] Warn when disassembling a v_cmpx with non-exec destination

Joe Nash via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 06:35:23 PDT 2023


Joe_Nash added a comment.

>> - Wrap the check in DEBUG and print to dbgs() ?
>
> I am not sure how that helps. I wrapped the warning-emission in `LLVM_DEBUG` and added `-debug`, the warning still does not sync with the instruction it corresponds to. Unless I did not understand this option correctly.

This would help with the issue raised by Jay "when the disassembler is being used as a library then it's probably not appropriate for it just to write warnings to stderr." The warning being unsynced seems like a separate issue.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147424/new/

https://reviews.llvm.org/D147424



More information about the llvm-commits mailing list