[PATCH] D149646: [LLVM][Uniformity] Propagate temporal divergence explicitly

Sameer Sahasrabuddhe via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 05:50:15 PDT 2023


sameerds created this revision.
Herald added subscribers: kosarev, kerbowa, mgrang, hiraditya, jvesely.
Herald added a project: All.
sameerds requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

At a cycle C with divergent exits, UA was using a naive traversal of the exiting
edges to locate blocks that may use values defined inside C. But this traversal
fails when it encounters a cycle. This is now replaced with a much simpler
propagation that iterates over every instruction in C and checks any uses that
are outside C. But such an iteration can be expensive when C is very large; the
original strategy may need to be reconsidered if there is a regression in
compilation times.

Also fixed lit tests that should have originally caught the missed propagation
of temporal divergence.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D149646

Files:
  llvm/include/llvm/ADT/GenericUniformityImpl.h
  llvm/lib/Analysis/UniformityAnalysis.cpp
  llvm/lib/CodeGen/MachineUniformityAnalysis.cpp
  llvm/test/Analysis/UniformityAnalysis/AMDGPU/temporal_diverge.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D149646.518693.patch
Type: text/x-patch
Size: 7848 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20230502/4de76b07/attachment.bin>


More information about the llvm-commits mailing list