[PATCH] D149635: [libunwind] include alloca.h in config.h

Reagan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 03:28:15 PDT 2023


xbjfk added a comment.

> Indeed. In particular, mingw toolchains don't have an alloca.h header - this should show up as failure from those jobs in CI.

I see, maybe in this case alloca.h should only be included in the `#ifndef _LIBUNWIND_REMEMBER_HEAP_ALLOC` and under `__has_include`? not sure whether this is acceptable.
or is this problem something for picolibc to solve? or the user by specifying `-include alloca.h`? how should this be fixed instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149635/new/

https://reviews.llvm.org/D149635



More information about the llvm-commits mailing list