[PATCH] D98437: [SystemZ][z/OS] Add GOFFObjectFile class support for HDR, ESD and END records

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 2 02:45:44 PDT 2023


RKSimon added inline comments.


================
Comment at: llvm/unittests/Object/GOFFObjectFileTest.cpp:19
+namespace {
+char GOFFData[GOFF::RecordLength * 3] = {0x00};
+
----------------
@yusra.syeda I've pushed a less than ideal fix at da942fee5bb80c2fb81fbb914304e94103cc25a5 to silence a lot of constant truncation warnings on MSVC builds - but it'd be better if you could use unsigned char here instead


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98437/new/

https://reviews.llvm.org/D98437



More information about the llvm-commits mailing list