[PATCH] D149611: [LLD][COFF] Allow overwriting directives exports with cmd-line exports

Tue May 2 02:20:09 PDT 2023

alvinhochun added inline comments.

================
Comment at: lld/test/COFF/export.test:17
 CHECK2:      DLL name: export.test.tmp.dll
+CHECK2:      Ordinal base: 5
 CHECK2:      Ordinal      RVA  Name
----------------
alvinhochun wrote:
> This seems to depend on changes to llvm-objdump? There should be a separate parent patch to add this output.
> 
> Also this patch despite being marked as depending on D149610 somehow does not include the changes in it.
Sorry, I missed that this line already exists in the current output of llvm-objdump. The second point still applies though.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149611/new/

https://reviews.llvm.org/D149611